Request a code review
Request a code review of a branch or changeset in the Unity Dashboard, respond to comments, resolve change requests, and merge the reviewed changes.
Read time 3 minutesLast updated 5 days ago
Request a code review to ask other users to check your changes before you merge them. When you get the review, you can respond to the reviewers' comments, resolve their change requests, and merge the changes when the review is complete.
Request a review
To request a code review of a branch or changeset:
- Open the repository, then select the Branches or Changesets tab.
- Do one of the following:
- Select New review next to the branch or changeset that you want reviewed.
- Open a changeset, then select New review.
- On the Request a review page, check the Source and Destination fields. Source is the branch or changeset to review, and Destination is the branch to merge it into. To swap them, select the arrows between the fields.
- In the Title field, keep the suggested title or enter a new one. The title is required.
- From the Reviewers list, select the users or user groups that you want to review the code.
- In the Description field, describe the changes for the reviewers. To check the formatting, select Preview.
- To check the changes before you request the review, select the Changed Files or Changesets tab.
- Select Save.
The reviewers you selected can now open the code review from the Code reviews tab.
Respond to comments and resolve questions
After you request a code review, reviewers can add comments, ask questions, and request changes. You can respond to comments and resolve questions in the Unity Dashboard.
To respond to a comment or resolve a question:
- Find the comment in the Conversation tab or the Changed Files tab. For more information, refer to View comments.
- Enter your answer.
- Select Reply or Resolve question.
Resolve change requests
To resolve a change request, make the requested changes in the code, then mark the change request as resolved.
Resolve a change request in the Unity Dashboard
You can check in changes in the Unity Version Control (UVCS) desktop application, Gluon, or the command line, then manually resolve the change request in the Unity Dashboard.
To resolve a change request in the Unity Dashboard:
- Make the changes in your repository and check them in.
- Open the change request comment in the Unity Dashboard. For more information, refer to View comments.
- Enter a comment that describes your changes.
- Select Resolve change request.
- Select the changeset with your changes.
- Select Mark as resolved.
Resolve a change request when you check in
You can also make your changes in the UVCS desktop application, and automatically resolve the change request when you check in the changes.
To resolve a change request when you check in your changes:
- In your workspace, make the requested changes on the branch.
- Open the Pending Changes tab.
- Select Close change requested in review.
- Select the change request that these changes resolve. To resolve more than one change request, select each one.
- Select Check in.
UVCS adds the GUID of the change request to the changeset comment. The change request then automatically displays as Resolved in the Unity Dashboard, and shows a link to the changeset that you checked in. To resolve a change request from the command line, refer to Code reviews in the desktop application.
Merge a completed code review
To merge a code review after a reviewer marks it as Reviewed:
- Open the code review.
- Select Merge. The Merge page opens. Nothing merges yet.
- On the Merge page, confirm the merge.
The changes merge into the destination branch. For more information, refer to Statuses.